Skill

Code Review

Matt Pocock

Workflow

Reviews a diff since a fixed point along two axes at once: whether the code follows the repo's own documented standards, and whether it does what the originating ticket actually asked for. The second axis is the unusual one - it catches work that is clean but off-brief.

A situation it fits

The PR is clean: tests pass, lint is green, the code is tidy. You still have a nagging feeling it solves a slightly different problem from the one the ticket described.

Code Review. All four read your diff, so the tie-break is what they compare it AGAINST. Only this one reads the originating ticket and checks the code against what was actually asked for. The others grade the code on its own merits, and code that is excellent but off-brief passes every one of them.

2 scenarios in the bank answer to Code Review. The rest are in the game.

Skills it gets confused with

These share a family with Code Review, which is another way of saying they are the ones you might reach for by mistake.

Knowing what Code Review does is the easy half. Telling it apart from the others under time pressure is the game.

Today's session

Code Review is part of mattpocock/skills. Licence: MIT. The description above was written for this game, not taken from the skill.